Merged
Conversation
added 8 commits
February 10, 2026 10:21
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a scatter-enabled Ludlow mass–concentration–redshift (MCR) variant for the cored NFW (cNFW) spherical mass profile, wiring it into the public mass-profile API and providing prior configuration and tests.
Changes:
- Added
cNFWMCRScatterLudlowSphprofile using Ludlow MCR with a configurablescatter_sigma. - Exposed the new profile through
autogalaxy.profiles.massandautogalaxy.profiles.mass.darkexports and added a priors YAML. - Extended existing NFW scatter tests with coverage for the new cNFW scatter spherical profile.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test_autogalaxy/profiles/mass/dark/test_nfw_scatter.py | Adds a new test for cNFWMCRScatterLudlowSph scale-radius changes with scatter. |
| autogalaxy/profiles/mass/dark/cnfw_mcr_scatter.py | Introduces the new cNFW Ludlow MCR scatter spherical profile. |
| autogalaxy/profiles/mass/dark/cnfw.py | Changes cNFWSph convergence/potential from raising to returning zeros. |
| autogalaxy/profiles/mass/dark/init.py | Re-exports the new scatter cNFW MCR class. |
| autogalaxy/profiles/mass/init.py | Re-exports the new scatter cNFW MCR class at the mass-package level. |
| autogalaxy/config/priors/mass/dark/cnfw_mcr_scatter.yaml | Adds prior configuration for cNFWMCRScatterLudlowSph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added scatter version of cnfw_mcr