perf: remove unused astropy.modeling import from convert.py#331
Merged
perf: remove unused astropy.modeling import from convert.py#331
Conversation
The `from astropy.modeling import InputParameterError` and `from docutils.io import InputError` imports were unused but pulled in the entire astropy.modeling stack (including dask.array and a cupy probe), adding ~1.2s to import time. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove two unused imports from
autogalaxy/convert.py:from astropy.modeling import InputParameterErrorandfrom docutils.io import InputError. Neither symbol is used anywhere in the file, but the astropy import pulls in the entireastropy.modelingstack (includingastropy.nddata→dask.array→ cupy probe), adding ~1.2s to import time.Part of PyAutoLabs/PyAutoLens#426.
API Changes
None — internal changes only.
Test Plan
pytest test_autogalaxy/ -x— 811 passed (tested with lazy-imports changes)Full API Changes (for automation & release notes)
Removed (internal only)
from astropy.modeling import InputParameterErrorinautogalaxy/convert.pyfrom docutils.io import InputErrorinautogalaxy/convert.py🤖 Generated with Claude Code