perf: cache galaxy_model_image_dict and model_images_of_planes_list#424
Merged
perf: cache galaxy_model_image_dict and model_images_of_planes_list#424
Conversation
Change from @Property to @cached_property to avoid recomputing the full ray-tracing chain 4 times per subplot_fit_imaging call. The subplot accesses these via _get_source_vmax, per-plane panels, and subtracted_images_of_planes_list — now all share the single cached result. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change
galaxy_model_image_dictandmodel_images_of_planes_listfrom@propertyto@cached_propertyonFitImaging. These were being recomputed 4 times persubplot_fit_imagingcall (by_get_source_vmax, lens plane panel, source plane panel, andsubtracted_images_of_planes_list), each triggering the full ray-tracing chain.API Changes
None —
cached_propertyis already imported from autoconf. Callers see no difference.Test Plan
subplot_fit_imaging: 3.9s → 1.9s (before other optimizations)🤖 Generated with Claude Code