[fix]fix tmpfs bug#8970
Merged
BernardXiong merged 7 commits intoRT-Thread:masterfrom Jun 13, 2024
zhuzhuzhus:zhujiale
Merged
Conversation
|
zhujiale seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
polarvid
suggested changes
May 23, 2024
polarvid
suggested changes
Jun 11, 2024
Comment on lines
+47
to
+49
| LOG_E("errno=%d, ret=%d\n", errno, ret); | ||
| LOG_E("cp test test1 error"); | ||
| uassert_false(1); |
Contributor
There was a problem hiding this comment.
很多缩进有问题。建议装个 clangd 之类的,提交之前自动调整一下。
polarvid
approved these changes
Jun 12, 2024
BernardXiong
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
在测试文件系统时发现在将/etc下的文件拷贝到/tmp下时:
能够正常读出文件,但是写入的时候就会有问题
在将/tmp下的文件拷贝至/tmp文件夹下时,读写都会出现问题,所以推断出tmpfs下读写都会出现问题,所以用qemu跟了一下读写该文件系统的过程。
你的解决方案是什么 (what is your solution)
tmp文件系统读写过程中,执行dfs_tmpfs_read时,由于file->vnode->size是无符号类型,所以在进行if(count < file->vnode->size - ops)这一步时会导致如果size小于ops时,减出来的数不是负数,而是一个非常大的正数,这样会导致即使文件没有内容读了。也会执行memcpy(buf, &(d_file->data[*pos]), length);这个函数,进而导致内存报错,所以在该函数中强制转换了一部分数据类型,目前运行正常,我编写了一个utest在rt-thread/examples/utest/testcases/dfs/tmpfs目录下,目前已经可以正常通过测试。
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up