[ht32][drv]新增了CAN、USB和SDIO的驱动文件 by QT-one · Pull Request #9876 · RT-Thread/rt-thread

QT-one · 2025-01-07T02:08:11Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

新增了CAN、USB和SDIO的驱动文件

你的解决方案是什么 (what is your solution)

新增的驱动文件已经分别在合泰的ESK32-30522和ESK32-30105开发板中验证通过。

请提供验证的bsp和config (provide the config and bsp)

BSP:
.config:
action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
[] 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

CLAassistant · 2025-01-07T02:08:17Z

All committers have signed the CLA.

supperthomas · 2025-01-07T06:04:16Z

建议添加yml文件参考如下。
https://club.rt-thread.org/ask/article/5c41835bb8ff9b41.html

QT-one · 2025-01-07T08:22:29Z

@supperthomas 根据检测的反馈，这里应该是缺少了一个宏定义。本来这个宏定义是一个全局宏定义的，我将它写在了Scons脚本里，生成的keil 5工程，在编译过程中是没有问题的，但使用ENV进行编译的话就会反馈没有检测到这些全局宏定义。yml文件的话，我之前有在".github/workflow/bsp_buildings.yml"中增加过了，所以应该不是这个问题。

supperthomas · 2025-01-07T09:16:50Z

bsp/ht32/ht32f12366/rtconfig.py

    CFLAGS = DEVICE + ' -Dgcc'
    AFLAGS = ' -c' + DEVICE + ' -x assembler-with-cpp -Wa,-mimplicit-it=thumb '
    LFLAGS = DEVICE + ' -Wl,--gc-sections,-Map=rt-thread.map,-cref,-u,Reset_Handler -T board/linker_scripts/link.lds'
-    CFLAGS += ' -D  USE_HT32F12365_66'


这里为什么要删掉呢？

supperthomas · 2025-01-07T09:17:40Z

bsp/ht32/ht32f52352/rtconfig.py

    CFLAGS = DEVICE + ' -Dgcc'
    AFLAGS = ' -c' + DEVICE + ' -x assembler-with-cpp -Wa,-mimplicit-it=thumb '
    LFLAGS = DEVICE + ' -Wl,--gc-sections,-Map=rt-thread.map,-cref,-u,Reset_Handler -T board/linker_scripts/link.lds'
-    CFLAGS += ' -D USE_HT32F52342_52'


QT-one · 2025-01-07T10:17:29Z

@supperthomas 我是在老一版本的库上进行更新的，拉取新版库后直接就复制替换了，没有留意到这部分的改变，刚才检查了下这部分确实更新了，非常感谢您的提醒。

supperthomas · 2025-01-07T11:32:16Z

请阅读一下：https://club.rt-thread.org/ask/article/5c41835bb8ff9b41.html
另外，请删除和PR无关的一些配置文件，如果不需要添加，不需要都添加。

supperthomas · 2025-01-09T03:43:34Z

bsp/ht32/ht32f53252/README.md

+- 进阶使用方法
+
+通过阅读快速上手章节开发者可以快速地上手该 BSP，将 RT-Thread 运行在开发板上。
+


如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

.github/workflows/bsp_buildings.yml

supperthomas · 2025-01-09T11:00:06Z

.github/workflows/bsp_buildings.yml

                - "nrf5x/nrf52833"
                - "nrf5x/nrf52840"
                - "nrf5x/nrf5340"
+                - "ht32/ht32f53252"


- RTT_BSP: "others_at32_hc32_ht32" RTT_TOOL_CHAIN: "sourcery-arm" SUB_RTT_BSP: - "qemu-vexpress-a9" - "airm2m/air32f103" ... - "ht32/ht32f53252"

所以这里是需要删除nordic(yml)里的"ht32/ht32f53252"，保留others_at32_hc32_ht32中的是吗？

mysterywolf · 2025-01-12T17:52:19Z

bsp/ht32/ht32f52352/rtconfig.h


 /* Onboard Peripheral Drivers */

+#define BSP_USING_TEST


请把这个选项关掉

mysterywolf · 2025-01-12T17:52:50Z

bsp/ht32/ht32f52352/rtconfig.h

+
+/* rt_vsscanf options */
+
+#define RT_KLIBC_USING_LIBC_VSSCANF


请把这个选项关掉

mysterywolf · 2025-01-12T17:53:41Z

bsp/ht32/ht32f52352/board/Kconfig

            config BSP_USING_SPI0
                bool "Enable SPI0 Bus"
-                default n
+                default y


SPI0和I2C0为什么默认开启呢，一般BSP只默认开启GPIO和一个用于console调试的串口

mysterywolf · 2025-01-12T17:54:22Z

bsp/ht32/ht32f53252/board/Kconfig

+        if BSP_USING_SPI
+            config BSP_USING_SPI0
+                bool "Enable SPI0 Bus"
+                default y


这个默认开启是有什么需求吗

mysterywolf · 2025-01-12T17:54:31Z

bsp/ht32/ht32f53252/board/Kconfig

+                if BSP_USING_I2C_HW
+                    config BSP_USING_I2C0_HW
+                    bool "Enable Hardware I2C0 Bus"
+                    default y


mysterywolf · 2025-01-12T17:54:52Z

bsp/ht32/ht32f53252/rtconfig.h

+
+/* rt_vsnprintf options */
+
+#define RT_KLIBC_USING_LIBC_VSNPRINTF


请关闭这个选项

mysterywolf · 2025-01-12T17:55:01Z

bsp/ht32/ht32f53252/rtconfig.h

+
+/* rt_vsscanf options */
+
+#define RT_KLIBC_USING_LIBC_VSSCANF


请关闭这个选项

mysterywolf · 2025-01-12T17:55:45Z

bsp/ht32/ht32f53252/rtconfig.h

+
+/* Onboard Peripheral Drivers */
+
+#define BSP_USING_TEST


请关闭这个选项，这个选项是否打开留给用户，我们配置好就行，用户一键打开。

QT-one added 2 commits January 7, 2025 09:43

新增CAN、USB、SDIO驱动

2f013d9

规范文件格式

6efc6c5

github-actions bot added the BSP label Jan 7, 2025

supperthomas requested changes Jan 7, 2025

View reviewed changes

QT-one and others added 3 commits January 8, 2025 13:30

Merge branch 'RT-Thread:master' into master

89c9e76

Merge branch 'RT-Thread:master' into master

f0dfad5

修正格式以及编译问题

c60242b

QT-one requested a review from supperthomas January 9, 2025 01:08

supperthomas requested changes Jan 9, 2025

View reviewed changes

QT-one and others added 2 commits January 9, 2025 13:14

Merge branch 'RT-Thread:master' into master

18399a9

添加CI检查

d6911ac

github-actions bot added the action github action yml imporve label Jan 9, 2025

QT-one requested a review from supperthomas January 9, 2025 08:20

supperthomas reviewed Jan 9, 2025

View reviewed changes

.github/workflows/bsp_buildings.yml Outdated Show resolved Hide resolved

去除多余的IC检查

c155c03

supperthomas requested changes Jan 9, 2025

View reviewed changes

QT-one and others added 2 commits January 10, 2025 09:23

Merge branch 'RT-Thread:master' into master

540ebd3

修正CI检查

f176e0c

supperthomas approved these changes Jan 10, 2025

View reviewed changes

QT-one requested a review from supperthomas January 10, 2025 02:09

mysterywolf requested changes Jan 12, 2025

View reviewed changes

QT-one and others added 2 commits January 13, 2025 09:38

Merge branch 'RT-Thread:master' into master

c038fa3

修正Kconfig配置

6fc7d0d

mysterywolf approved these changes Jan 13, 2025

View reviewed changes

mysterywolf merged commit 3436aa6 into RT-Thread:master Jan 13, 2025
45 checks passed

		- 进阶使用方法

		通过阅读快速上手章节开发者可以快速地上手该 BSP，将 RT-Thread 运行在开发板上。


		/* rt_vsnprintf options */

		#define RT_KLIBC_USING_LIBC_VSNPRINTF

Conversation

QT-one commented Jan 7, 2025

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

CLAassistant commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supperthomas commented Jan 7, 2025

Uh oh!

QT-one commented Jan 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QT-one commented Jan 7, 2025

Uh oh!

supperthomas commented Jan 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Jan 7, 2025 •

edited

Loading