fix: remove duplicate findEndpointNeighborsBatch — build fix#25
Merged
Conversation
… fix) The merge of feat/phase5-dashboard-redesign into main introduced a duplicate definition of findEndpointNeighborsBatch(List<String>). Both versions had identical semantics but different implementation style: Kept: the first (from the backend chain PRs #12-16) which uses NodeKind.ENDPOINT.getValue() for type safety and UNWIND/MATCH pattern with $ids parameter. Removed: the second (from phase5) which used string literals ('ENDPOINT', 'WEBSOCKET_ENDPOINT') and IN $nodeIds pattern. Fixes: compilation failure on main (javac error: method already defined). Co-Authored-By: Paperclip <noreply@paperclip.ing>
Two duplicate method definitions were introduced when feat/phase5-dashboard-redesign was merged into main, because both the backend chain (PRs #12-16) and the phase5 branch independently added the same methods: 1. GraphStore.findEndpointNeighborsBatch(List<String>): - Kept: UNWIND/$ids/NodeKind.getValue() version (from backend chain, type-safe) - Removed: IN $nodeIds/string literal version (from phase5) 2. TopicLinkerTest.determinismTest(): - Kept: multi-producer/multi-consumer test with PRODUCES+CONSUMES+PUBLISHES+LISTENS and TOPIC+EVENT nodes (more comprehensive, verifies target ID equality) - Removed: simpler 3-edge test (from backported detection-quality-fixes commit) Fixes: javac compilation failures on main branch. Co-Authored-By: Paperclip <noreply@paperclip.ing>
findRelatedEndpoints now partitions search matches into direct endpoints
(returned immediately) and non-endpoint nodes (passed to batch query).
Two tests were stubbing findEndpointNeighborsBatch with List.of("ep:getUsers")
but since ep:getUsers IS an endpoint, it never reaches the batch call —
nonEndpointIds is empty.
Update both tests to stub List.of() (the actual argument when all search
results are direct endpoint matches).
Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findEndpointNeighborsBatch(List<String>)method introduced during the phase5 merge conflictmain(java.lang.Error: method already defined)NodeKind.ENDPOINT.getValue()for type safetyRoot Cause
The merge of
feat/phase5-dashboard-redesign→main(PR #24) introduced a duplicate method because both the backend chain (PRs #12-16) and the phase5 branch independently added the same batch lookup method with slightly different implementations.Test Plan
mvn compile)🤖 Generated with Claude Code