dcast only computes default fill if necessary#5549
Merged
MichaelChirico merged 32 commits intomasterfrom Mar 14, 2024
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5512
Closes #5390
In current master,
dcast(fill=NULL)always computes a default fill value, even when there are no missing cells. For example this is the result of a new test case using current masterIn the code above it is normal to compute the fill value (
fill_value=as.integer(min(integer()))which is NA) because it is used three times.However the code below gives the following result using current master, indicating that a default fill value is computed, even though it is not used:
Using this branch we get the output below (no warning), indicating that no default fill value was computed, because it is not necessary: