Add Coccinelle lint checks for non-_RO accessors used with pointers to const

.ci/linters/c/cocci_linter.R

@@ -10,12 +10,12 @@ cocci_linter = if (!nzchar(Sys.which("spatch"))) function(...) {} else function(
       stdout = TRUE, stderr = FALSE
     )
     if (length(out) > 0) {
-      cat(sprintf("In file '%s', Coccinelle linter '%s' located the following problems:\n", c_obj$path, spfile))
+      cat(sprintf("In file '%s', Coccinelle linter '%s' located the following problems:\n", c_obj$c_obj, spfile))
       writeLines(out)
       bad = TRUE
     }
     if (!is.null(status <- attr(out, 'status'))) {
-      cat(sprintf("While working on file '%s', Coccinelle linter '%s' failed with exit code %d:\n", c_obj$path, spfile, status))
+      cat(sprintf("While working on file '%s', Coccinelle linter '%s' failed with exit code %d:\n", c_obj$c_obj, spfile, status))
       bad = TRUE
     }
   }

.ci/linters/cocci/use_ro_accessors.cocci

@@ -0,0 +1,78 @@
+@@
+type T;
+const T *variable;
+expression E;
+@@
+- variable = REAL(E)
++ variable = REAL_RO(E)
+
+@@
+type T;
+const T *variable;
+expression E;
+@@
+- variable = INTEGER(E)
++ variable = INTEGER_RO(E)
+
+@@
+type T;
+const T *variable;
+expression E;
+@@
+- variable = COMPLEX(E)
++ variable = COMPLEX_RO(E)
+
+@@
+type T;
+const T *variable;
+expression E;
+@@
+- variable = RAW(E)
++ variable = RAW_RO(E)
+
+@@
+type T;
+const T *variable;
+expression E;
+@@
+- variable = LOGICAL(E)
++ variable = LOGICAL_RO(E)
+
+@@
+expression E;
+@@
+-(const int*) INTEGER(E)
++INTEGER_RO(E)
+
+@@
+expression E;
+@@
+-(const double*) REAL(E)
++REAL_RO(E)
+
+@@
+expression E;
+@@
+-(const int*) LOGICAL(E)
++LOGICAL_RO(E)
+
+@@
+expression E;
+type T;
+@@
+-(const T*) RAW(E)
++RAW_RO(E)
+
+@@
+expression E;
+type T;
+@@
+-(const T*) COMPLEX(E)
++COMPLEX_RO(E)
+
+@@
+expression E;
+type T;
+@@
+-(const T*) STRING_PTR(E)
++STRING_PTR_RO(E)

.github/workflows/code-quality.yaml

@@ -29,6 +29,7 @@ jobs:
             c:
               - '**/*.c'
               - '**/*.h'
+              - '.ci/linters/cocci/**/*.cocci'
             po:
               - 'po/**/*.po'
             md: