Conversation
ben-schwen
requested review from
HughParsonage and
MichaelChirico
as code owners
Generated via commit 404cdd8 Download link for the artifact containing the test results: ↓ atime-results.zip
|
On old Rtools installation now produces the following messages: make: pkg-config: Command not found
| fwrite(DT, file=f5<-tempfile(), compress="zstd", compressLevel=22) | ||
| fwrite(DT, file=f6<-tempfile(), compress="zstd", col.names=FALSE) | ||
| test(1658.5441, file.info(f3)$size, file.info(f1)$size) | ||
| test(1658.5442, file.info(f4)$size >= file.info(f1)$size) |
There was a problem hiding this comment.
On Windows, file.size(f4) (58) is below file.size(f1) (63). On my GNU/Linux, both are 60 bytes in size.
| if (!haszstd()) | ||
| stopf("To read .zst files, fread() requires zstd library support. data.table was compiled without zstd. Please reinstall data.table after installing the zstd development library (libzstd-dev on Debian/Ubuntu, libzstd-devel on Fedora/EPEL, zstd on Homebrew).") # nocov | ||
| tryCatch({ | ||
| .Call(Cdt_zstd_decompress, file, decompFile) |
There was a problem hiding this comment.
Since this line precedes file = enc2native(file), file could be encoded in UTF-8 on a non-UTF-8 system (e.g. modern R on old Windows). zstd_decompress should probably use translateChar() instead of CHAR().
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7671 +/- ##
==========================================
- Coverage 99.04% 99.00% -0.04%
==========================================
Files 87 87
Lines 17031 17101 +70
==========================================
+ Hits 16868 16931 +63
- Misses 163 170 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Closes #7457
Also add
xzfile()support for reading files (seemed missing since we supportbzfile()but ofc implicitly support by reading from connections now)