Skip to content

Add maxConcurrent parameter to flatMapIterable#3722

Merged
stevegury merged 1 commit intoReactiveX:1.xfrom
lukaciko:flatMapIterable-maxConcurrent
Mar 3, 2016
Merged

Add maxConcurrent parameter to flatMapIterable#3722
stevegury merged 1 commit intoReactiveX:1.xfrom
lukaciko:flatMapIterable-maxConcurrent

Conversation

@lukaciko
Copy link
Copy Markdown

Refs #3711. Should these new overloaded functions be annotated with @Beta?

@lukaciko
Copy link
Copy Markdown
Author

The failing test (testNoMoreRequestsAfterUnsubscribe) seems unrelated. All tests pass locally.

@akarnokd
Copy link
Copy Markdown
Member

If you could add one unit test for each method that verifies maxConcurrent is honored, that would be great.

@lukaciko
Copy link
Copy Markdown
Author

While writing the test I figured you might have been right when commenting on issue #2627. If I am not mistaken all the observables created with OperatorMapPair.convertSelector use the same scheduler (there is no way to subscribe them to different schedulers) and thus are run sequentially and until completion. Would adding a Scheduler parameter make sense?

@akarnokd
Copy link
Copy Markdown
Member

There is no scheduler involved here so no.

@akarnokd
Copy link
Copy Markdown
Member

akarnokd commented Mar 3, 2016

👍 as it is now

@stevegury
Copy link
Copy Markdown
Member

👍

stevegury added a commit that referenced this pull request Mar 3, 2016
Add maxConcurrent parameter to flatMapIterable
@stevegury stevegury merged commit 2343989 into ReactiveX:1.x Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants