Skip to content

[pydrake] Avoid deprecated Jupyter kernel method#23676

Merged
sammy-tri merged 1 commit intoRobotLocomotion:masterfrom
tyler-yankee:ipykernel-7.1
Nov 3, 2025
Merged

[pydrake] Avoid deprecated Jupyter kernel method#23676
sammy-tri merged 1 commit intoRobotLocomotion:masterfrom
tyler-yankee:ipykernel-7.1

Conversation

@tyler-yankee
Copy link
Copy Markdown
Contributor

@tyler-yankee tyler-yankee commented Oct 30, 2025

Mirror the new upstream implementation as of ipykernel==7.1.0. This remains backwards compatible with ipykernel<7.1.0.

See ipython/ipykernel#1458 for the upstream change.

Towards #23668.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added release notes: fix This pull request contains fixes (no new features) priority: medium labels Oct 30, 2025
Copy link
Copy Markdown
Contributor Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess at least part of the implementation is not backwards compatible.

Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers

Mirror the new upstream implementation as of ipykernel==7.1.0. This
remains backwards compatible with ipykernel<7.1.0.
Copy link
Copy Markdown
Contributor Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should +a:@rpoyner-tri review this one, please? feel free to delegate as needed

Reviewable status: LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers

Copy link
Copy Markdown
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@rpoyner-tri reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: needs at least two assigned reviewers

Copy link
Copy Markdown
Contributor Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+a:@sammy-tri for platform review (per schedule, tomorrow) please.

Reviewable status: LGTM missing from assignee sammy-tri(platform)

Copy link
Copy Markdown
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@sammy-tri reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),sammy-tri(platform)

@sammy-tri sammy-tri merged commit ebf264d into RobotLocomotion:master Nov 3, 2025
9 checks passed
@tyler-yankee tyler-yankee deleted the ipykernel-7.1 branch November 13, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: medium release notes: fix This pull request contains fixes (no new features)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants