[pydrake] Avoid deprecated Jupyter kernel method#23676
[pydrake] Avoid deprecated Jupyter kernel method#23676sammy-tri merged 1 commit intoRobotLocomotion:masterfrom
Conversation
tyler-yankee
left a comment
There was a problem hiding this comment.
Guess at least part of the implementation is not backwards compatible.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers
d55f8b7 to
0f9d350
Compare
Mirror the new upstream implementation as of ipykernel==7.1.0. This remains backwards compatible with ipykernel<7.1.0.
tyler-yankee
left a comment
There was a problem hiding this comment.
should +a:@rpoyner-tri review this one, please? feel free to delegate as needed
Reviewable status: LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers
rpoyner-tri
left a comment
There was a problem hiding this comment.
@rpoyner-tri reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: needs at least two assigned reviewers
tyler-yankee
left a comment
There was a problem hiding this comment.
+a:@sammy-tri for platform review (per schedule, tomorrow) please.
Reviewable status: LGTM missing from assignee sammy-tri(platform)
sammy-tri
left a comment
There was a problem hiding this comment.
@sammy-tri reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),sammy-tri(platform)
Mirror the new upstream implementation as of ipykernel==7.1.0. This remains backwards compatible with ipykernel<7.1.0.
See ipython/ipykernel#1458 for the upstream change.
Towards #23668.
This change is