Skip to content

fix: persist auto-approve detail settings immediately#12049

Open
suyua9 wants to merge 1 commit intoRooCodeInc:mainfrom
suyua9:fix/autoapprove-sync-suyua9
Open

fix: persist auto-approve detail settings immediately#12049
suyua9 wants to merge 1 commit intoRooCodeInc:mainfrom
suyua9:fix/autoapprove-sync-suyua9

Conversation

@suyua9
Copy link
Copy Markdown

@suyua9 suyua9 commented Apr 3, 2026

Summary

Fixes #12038 by persisting auto-approve detail settings immediately instead of leaving them only in the settings view cache.

Root Cause

autoApprovalEnabled already syncs to the extension host immediately, but the related permission details in AutoApproveSettings were only stored in SettingsView's local cachedState until the user explicitly saved settings.

That mismatch meant a second VS Code window could inherit the global auto-approve master toggle while still missing the actual per-action allowlist state, so Roo kept prompting for approvals.

Fix

  1. Add a small syncAutoApproveSettings() helper in AutoApproveSettings.tsx
  2. Reuse it whenever auto-approve toggles, limits, or follow-up timeout settings change
  3. Keep the change tightly scoped to the auto-approve settings surface so the rest of the settings workflow is unchanged

Testing

  • git diff --check
  • Did not run project tests locally in this environment

Interactively review PR in Roo Code Cloud

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Auto-approve settings not synchronized across multiple VS Code windows

1 participant