fix: persist auto-approve detail settings immediately#12049
Open
suyua9 wants to merge 1 commit intoRooCodeInc:mainfrom
Open
fix: persist auto-approve detail settings immediately#12049suyua9 wants to merge 1 commit intoRooCodeInc:mainfrom
suyua9 wants to merge 1 commit intoRooCodeInc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12038 by persisting auto-approve detail settings immediately instead of leaving them only in the settings view cache.
Root Cause
autoApprovalEnabledalready syncs to the extension host immediately, but the related permission details inAutoApproveSettingswere only stored inSettingsView's localcachedStateuntil the user explicitly saved settings.That mismatch meant a second VS Code window could inherit the global auto-approve master toggle while still missing the actual per-action allowlist state, so Roo kept prompting for approvals.
Fix
syncAutoApproveSettings()helper inAutoApproveSettings.tsxTesting
git diff --checkInteractively review PR in Roo Code Cloud