Fix glibc-2.43 constness warnings#867
Open
hhoffstaette wants to merge 1 commit intoRsyncProject:masterfrom
Open
Fix glibc-2.43 constness warnings#867hhoffstaette wants to merge 1 commit intoRsyncProject:masterfrom
hhoffstaette wants to merge 1 commit intoRsyncProject:masterfrom
Conversation
Glibc 2.43 added C23 const-preserving overloads to various string functions, which change the return type depending on the constness of the argument(s). Currently this leads to warnings from calls to strtok() or strchr(). Fix this by properly declaring the respective variable types. Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Contributor
Author
|
zlib on MacOS won't build with -std=gnu23 because of old-style protoypes, but that's a zlib problem. It only now surfaces because (presumably) the Homebew action already has autoconf-2.73, which tries to force C23 and therefore makes clang reject old prototypes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glibc 2.43 added C23 const-preserving overloads to various string functions, which change the return type depending on the constness of the argument(s). Currently this leads to warnings from calls to strtok() or strchr() which can break the build e.g. when -Werror is used. Fix this by properly declaring the respective variable types.