rust/kernel: remove config #ifdef in mutex.rs file#357
Merged
ojeda merged 1 commit intoRust-for-Linux:rustfrom Jun 8, 2021
Merged
rust/kernel: remove config #ifdef in mutex.rs file#357ojeda merged 1 commit intoRust-for-Linux:rustfrom
#ifdef in mutex.rs file#357ojeda merged 1 commit intoRust-for-Linux:rustfrom
Conversation
The use of `#ifdef CONFIG_` statements in .c/.rs files should be avoided: it makes the code much more unmaintainable over time. See: https://lore.kernel.org/lkml/YLjWKwhp7akqyR1S@kroah.com/ Use a Rust-C helper instead to leverage automatic `CONFIG` selection in C kernel headers. Signed-off-by: Sven Van Asbroeck <thesven73@gmail.com>
Member
|
Review of
|
Member
|
LGTM |
wedsonaf
approved these changes
Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of
#ifdef CONFIG_statements in .c/.rs files should beavoided: it makes the code much more unmaintainable over time. See:
https://lore.kernel.org/lkml/YLjWKwhp7akqyR1S@kroah.com/
Use a Rust-C helper instead to leverage automatic
CONFIGselectionin C kernel headers.
Signed-off-by: Sven Van Asbroeck thesven73@gmail.com