Allow cursor autohide with keep_with_cursor=no while hovering osc

[Keith94]

Reproduction Steps

1. keep_with_cursor=no in modernz.conf
2. cursor-autohide=2000 in mpv.conf
3. Hover the pause button and let the osc fade out.

Expected Behavior

The cursor autohides 2 seconds after mouse cursor stops

Actual Behavior

The cursor autohides 2 seconds after osc fully fades out

Log File

No response

I carefully read all instructions and confirm that I did the following:

• I tested with the latest mpv version to validate that the issue is not already fixed.
• I provided all required information.

[Samillion]

This is intended behavior to not hide the mouse while hovering an input area (OSC or WC).

I'm not sure if this is good to adjust or no. However, it is simple to do, so test and let me know, please.

In your steps, hover the pause button: The cursor will hide, but it's still glowing/hovered.

Test script: modernz.lua
Commit: cd85599

Changes:

• Respect cursor hide option in mpv.conf if OSC or WC are hovered
  • Include allow-hide-cursor in all keybindings

[Keith94]

Wow, you are awesome. It works great for me.

How difficult is it to apply that specific fix only if osc_keep_with_cursor is disabled?

[Samillion]

Test script: modernz.lua
Commit: 3724c5c

Changes:

• Tie cursor hide flag with osc_keep_with_cursor=no
  • Add cursor_hide_flag state, initiated as nil
  • Adjust cursor_hide_flag state in validate_user_opts() according to osc_keep_with_cursor status

[Keith94]

Thank you, it looks promising. Will check in a few hours.

[Keith94]

It is much better now that it only affects that option.

I have just one minor request, if an element is being held down, such as the seekbar, can we keep cursor visible in this case? Essentially, only let the cursor auto hide after x miliseconds once an element is not pressed down anymore.

[Samillion]

Would this work?

state.cursor_hide_flag = (not user_opts.osc_keep_with_cursor and not state.active_element) and "allow-hide-cursor" or nil

Or:

state.cursor_hide_flag = (not user_opts.osc_keep_with_cursor and state.active_element > 0) and "allow-hide-cursor" or nil

[Keith94]

state.cursor_hide_flag = (not user_opts.osc_keep_with_cursor and not state.active_element) and "allow-hide-cursor" or nil

Not working sadly. Mouse still hides.

state.cursor_hide_flag = (not user_opts.osc_keep_with_cursor and state.active_element > 0) and "allow-hide-cursor" or nil

I get an error.
[modernz] Lua error: ...Data\Roaming\mpv\portable_config\script-opts\modernz.lua:4147: attempt to compare number with nil

[Samillion]

Oops, this would work I think:

state.cursor_hide_flag = (not user_opts.osc_keep_with_cursor and state.active_element) and "allow-hide-cursor" or nil

Removed not, since the use case: if element is active and osc_keep_with_cursor=no

Edit:
Wait, no hmmmm. My brain just farted.

[Samillion]

Would specifically checking if it's nil be needed here?

state.cursor_hide_flag = (not user_opts.osc_keep_with_cursor and state.active_element == nil) and "allow-hide-cursor" or nil

[Keith94]

For some reason the bastard cursor still hides. Sorry that I'm not much help here.

[Keith94]

if an element is being held down, such as the seekbar, can we keep cursor visible

I have a fix for this along with resetting hidetimeout on mouse up. Do you want to add it?

https://github.com/Keith94/ModernZ/blob/allow_cursor_hide_fix/modernz.lua

[Keith94]

Irrelevant now unless we add the feature back, or one day mpv-player/mpv#11973 gets fixed 🤞

[Samillion]

Ah, my bad. I'll add it back soon. keep_with_cursor