wrapping parens around Either's try and except#157
Open
bandophahita wants to merge 3 commits intoScreenPyHQ:trunkfrom
Open
wrapping parens around Either's try and except#157bandophahita wants to merge 3 commits intoScreenPyHQ:trunkfrom
bandophahita wants to merge 3 commits intoScreenPyHQ:trunkfrom
Conversation
bandophahita
force-pushed
the
issue_156
branch
2 times, most recently
from
03b1653 to
f40ec08
Compare
MarcelWilson
force-pushed
the
issue_156
branch
from
f40ec08 to
190d727
Compare
perrygoy
reviewed
Sep 27, 2025
tests/test_actions.py
Outdated
Comment on lines
+1183
to
+1184
| mock_action1 = FakeAction() | ||
| mock_action1.describe.return_value = "Do thing!" | ||
| act1 = FakeAction() | ||
| act1.describe.return_value = "Do thing!" |
Member
There was a problem hiding this comment.
quibble: I don't really understand the point of these changes... they're making it hard for me to see what you did in this file. I have a feeling it's just changing the parens in the expected strings, but i have to go through each line to look carefully for the changes and it also covers up any additional tests you had written.
It's annoying, but can you change the names back? I think it actually removes information from the test by taking out the mock_action base name.
Contributor
Author
There was a problem hiding this comment.
sure. I can also push this kind of change to a different PR. I saw that the pattern of tests didn't match, this was meant to keep them in sync.
This reverts commit 2ed2301.
bandophahita
force-pushed
the
issue_156
branch
from
bf3b31d to
c87f4b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #156