[dotnet] Hide unnecessary chromium public fields#17113
[dotnet] Hide unnecessary chromium public fields#17113nvborisenko merged 2 commits intoSeleniumHQ:trunkfrom
Conversation
PR TypeEnhancement Description
File Walkthrough
|
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Pull request overview
This PR reduces the public API surface of the .NET ChromiumDriver by changing several command-name/static fields from public to protected, limiting access to subclasses (e.g., ChromeDriver, EdgeDriver) rather than all consumers.
Changes:
- Changed multiple
ChromiumDriverstatic fields (command names andAcceptUntrustedCertificates) frompublictoprotected.
|
We're using SendChromeCommand to clear all cookies in all domains via Best regard, |
chrome.ExecuteCdpCommand("Network.clearBrowserCookies", []); |
|
Ah, it looked like ExecudeCdpCommand was obsoleted as well. |
still actual: |
This pull request makes a small but important change to the
ChromiumDriverclass by changing the visibility of several static fields frompublictoprotected. This limits their accessibility to the class itself and its subclasses, rather than exposing them publicly.publictoprotectedinChromiumDriver.cs:AcceptUntrustedCertificatesExecuteCdpGetCastSinksCommandSelectCastSinkCommandStartCastTabMirroringCommandStartCastDesktopMirroringCommandGetCastIssueMessageCommandStopCastingCommandGetNetworkConditionsCommandSetNetworkConditionsCommandDeleteNetworkConditionsCommandSendChromeCommandSendChromeCommandWithResultLaunchAppCommandSetPermissionCommand💡 Additional Considerations
Hopefully nobody even knows it exists. So just "remove".
🔄 Types of changes