Skip to content

MCP-324 Remove namespace from proxied servers#243

Merged
nquinquenel merged 1 commit intomasterfrom
task/nq/MCP-324-remove-namespace
Mar 4, 2026
Merged

MCP-324 Remove namespace from proxied servers#243
nquinquenel merged 1 commit intomasterfrom
task/nq/MCP-324-remove-namespace

Conversation

@nquinquenel
Copy link
Member

No description provided.

@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Mar 4, 2026

MCP-324

@nquinquenel nquinquenel force-pushed the task/nq/MCP-324-remove-namespace branch from 9943bea to 90b6602 Compare March 4, 2026 12:05
@nquinquenel nquinquenel marked this pull request as ready for review March 4, 2026 12:14
@nquinquenel nquinquenel force-pushed the task/nq/MCP-324-remove-namespace branch from 90b6602 to 06bf6f6 Compare March 4, 2026 12:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2026

SonarQube reviewer guide

Review in SonarQube

Summary: Remove the namespace field from proxied MCP server configuration and expose tools with their original names instead of prefixed names.

Review Focus:

  • The namespace field has been completely removed from the configuration model (ProxiedMcpServerConfig), parser, and all JSON configs. Ensure this breaking change is intentional and documented.
  • Tool naming has changed from namespaced format (e.g., context/analyze_code) to original names (e.g., analyze_code). This could cause collisions when multiple servers expose tools with identical names—verify this is acceptable or if there's a conflict resolution strategy.
  • The ToolMapping record signature changed, removing the namespace parameter. Check all callers are updated.
  • Test assertions were updated to match the new naming convention; verify the test expectations align with the desired behavior, especially in ProxiedToolsLoaderMediumTest where multiple servers now return only 2 tools instead of 4.

Start review at: src/main/java/org/sonarsource/sonarqube/mcp/client/ProxiedMcpServerConfig.java. This is the core data model change—removing the namespace field from the record definition and validation logic is the foundation for all downstream changes. Understanding the removal rationale here will clarify

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 Dependency risks

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nquinquenel nquinquenel merged commit 3be484c into master Mar 4, 2026
11 checks passed
@nquinquenel nquinquenel deleted the task/nq/MCP-324-remove-namespace branch March 4, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants