test(query-core/queriesObserver): add test for 'getObservers' method by sukvvon · Pull Request #10248 · TanStack/query

sukvvon · 2026-03-06T02:54:14Z

🎯 Changes

Add a test for queriesObserver.ts lines 168-169 — the getObservers() method that returns the internal observers array.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added a test verifying retrieval of current observers: it creates multiple queries, subscribes, advances timers, checks that observers are returned with the expected count and instances, and unsubscribes to ensure proper cleanup.

changeset-bot · 2026-03-06T02:54:20Z

⚠️ No Changeset found

Latest commit: 4787cca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-06T02:54:33Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8a230b0d-1170-43ef-9432-ff1313d70225

📥 Commits

Reviewing files that changed from the base of the PR and between e2b4147 and c1703c9.

📒 Files selected for processing (1)

packages/query-core/src/__tests__/queriesObserver.test.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

packages/query-core/src/tests/queriesObserver.test.tsx

📝 Walkthrough

Walkthrough

Adds a new test case to QueriesObserver tests that creates two queries, initializes a QueriesObserver, subscribes, advances timers, calls getObservers, asserts two QueryObserver instances are returned, then unsubscribes.

Changes

Cohort / File(s)	Summary
Test Addition `packages/query-core/src/__tests__/queriesObserver.test.tsx`	Adds a test "should return current observers via getObservers" that verifies `getObservers()` returns two `QueryObserver` instances for two tracked queries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 I hopped into the test suite bright,

I counted observers in the night,
Two little watchers, side by side,
getObservers showed them with pride,
A tiny hop, a passing bite.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a test for the 'getObservers' method in queriesObserver, which matches the changeset perfectly.
Description check	✅ Passed	The description follows the template structure, includes detailed changes explanation, completes all checklist items appropriately, and correctly indicates this is a dev-only change requiring no changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-03-06T02:54:37Z

View your CI Pipeline Execution ↗ for commit 4787cca

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	42s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-06 03:07:27 UTC

pkg-pr-new · 2026-03-06T02:57:33Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10248

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10248

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10248

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10248

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10248

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10248

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10248

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10248

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10248

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10248

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10248

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10248

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10248

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10248

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10248

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10248

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10248

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10248

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10248

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10248

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10248

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10248

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10248

commit: ede44e6

github-actions bot added the package: query-core label Mar 6, 2026

test(query-core/queriesObserver): add test for 'getObservers' method

c1703c9

sukvvon force-pushed the test/query-core-queriesObserver-getObservers branch from e2b4147 to c1703c9 Compare March 6, 2026 02:57

Merge branch 'main' into test/query-core-queriesObserver-getObservers

4787cca

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(query-core/queriesObserver): add test for 'getObservers' method#10248

test(query-core/queriesObserver): add test for 'getObservers' method#10248
sukvvon wants to merge 2 commits intoTanStack:mainfrom
sukvvon:test/query-core-queriesObserver-getObservers

sukvvon commented Mar 6, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 6, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Mar 6, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Mar 6, 2026 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Mar 6, 2026 •

edited

Loading

coderabbitai bot commented Mar 6, 2026 •

edited

Loading

nx-cloud bot commented Mar 6, 2026 •

edited

Loading

pkg-pr-new bot commented Mar 6, 2026 •

edited

Loading