[YouTube] Add comment reply count support by xz-dev · Pull Request #936 · TeamNewPipe/NewPipeExtractor

xz-dev · 2022-09-25T16:49:21Z

I carefully read the contribution guidelines and agree to them.
I have tested the API against NewPipe.
I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Add comment reply count support, just like youtube.

Fix #935

TobiGr

Thank you for that addition.

Please implement the tests for YouTube.

The reply count should also be extracted for the other services (e.g. PeerTube).

extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItemExtractor.java

AudricV

Additional changes that should be made.

Also, please remove the unneeded JavaDoc changes, which were probably made by your IDE.

extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItem.java

extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItemExtractor.java

Co-authored-by: AudricV <74829229+AudricV@users.noreply.github.com> Co-authored-by: AudricV <74829229+AudricV@users.noreply.github.com>

xz-dev · 2022-09-26T18:16:36Z

Additional changes that should be made.

Also, please remove the unneeded JavaDoc changes, which were probably made by your IDE.

Restored

TobiGr

Just some small things from my end

...g/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java

...rc/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeCommentsExtractorTest.java

Co-authored-by: Tobi <TobiGr@users.noreply.github.com>

TobiGr · 2022-09-26T21:08:53Z

The reply count should also be extracted for the other services (e.g. PeerTube).

Implementing this for PeerTube should be the same effort as you had with YouTube - less than ten lines. Can you please take care of it?

xz-dev · 2022-09-27T02:11:42Z

The reply count should also be extracted for the other services (e.g. PeerTube).

Implementing this for PeerTube should be the same effort as you had with YouTube - less than ten lines. Can you please take care of it?

We even not support get the PeerTube comment reply.
So, I think it's that's another job what we need to do but not in this PR.

xz-dev · 2022-09-28T03:53:07Z

I think the pull request is ready been merge, is there any questions?

...g/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java

TobiGr · 2022-10-07T10:04:58Z

I added a commit to fix exceptions when comments do not have replies and thus no replyCount (197d887)

TobiGr

Thank you. LGTM now

AudricV

A few changes remaining and this can be merged in my opinion.

Thank you for this feature!

...g/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java

...rc/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeCommentsExtractorTest.java

Co-authored-by: AudricV <74829229+AudricV@users.noreply.github.com>

AudricV

LGTM, thank you very much!

Please avoid in the future writing usernames with @ in commits, as if they contain these usernames in this form, you would probably send a GitHub notification each time the commits are rebased and/or pushed (that's what happened for me with your latest commits), including in repositories forks if I am not wrong.

This PR will be merged using the Squash and merge command.

xz-dev · 2022-10-15T05:57:50Z

Ok, I'll, usernames with @ in commits is github auto add it here, I don't know why github do that, so I keep it here.

Add comment reply count support of Youtube

4e5dec0

xz-dev mentioned this pull request Sep 25, 2022

Show comment replies TeamNewPipe/NewPipe#9020

Closed

5 tasks

TobiGr requested changes Sep 26, 2022

View reviewed changes

extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItemExtractor.java Outdated Show resolved Hide resolved

TobiGr added the enhancement New feature or request label Sep 26, 2022

Add UNKNOWN_REPLY_COUNT constant

b3c6f6f

AudricV requested changes Sep 26, 2022

View reviewed changes

xz-dev and others added 2 commits September 27, 2022 02:08

Add replyCount test for Youtube

36d1a12

Remove the unneeded changes

22237fa

Co-authored-by: AudricV <74829229+AudricV@users.noreply.github.com> Co-authored-by: AudricV <74829229+AudricV@users.noreply.github.com>

xz-dev requested review from AudricV and TobiGr and removed request for AudricV and TobiGr September 26, 2022 18:17

TobiGr reviewed Sep 26, 2022

View reviewed changes

AudricV removed their request for review September 26, 2022 19:14

xz-dev and others added 2 commits September 27, 2022 03:20

Update replyCount test for Youtube

659d6ae

Co-authored-by: Tobi <TobiGr@users.noreply.github.com>

Use UNKNOWN_REPLY_COUNT everywhere

4b4c7e8

xz-dev requested a review from TobiGr September 26, 2022 19:26

xz-dev requested review from AudricV and TobiGr and removed request for AudricV and TobiGr September 28, 2022 03:49

xz-dev mentioned this pull request Sep 28, 2022

How can we merge Pull Requests faster? TeamNewPipe/NewPipe#9040

Open

4 tasks

TobiGr reviewed Sep 28, 2022

View reviewed changes

...g/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java Show resolved Hide resolved

FireMasterK mentioned this pull request Sep 29, 2022

[YouTube] Add support to extract total comment count #794

Merged

3 tasks

Throw reply count parsing error in Youtube

c4f6a69

Fix crashes

197d887

TobiGr approved these changes Oct 7, 2022

View reviewed changes

AudricV changed the title ~~Add comment reply count support of Youtube~~ [YouTube] Add comment reply count support Oct 7, 2022

AudricV added the youtube service, https://www.youtube.com/ label Oct 7, 2022

TobiGr requested a review from AudricV October 7, 2022 16:41

AudricV requested changes Oct 8, 2022

View reviewed changes

TobiGr mentioned this pull request Oct 9, 2022

[PeerTube] Support comment replies #941

Merged

3 tasks

xz-dev and others added 2 commits October 14, 2022 10:46

Merge branch 'TeamNewPipe:dev' into dev

aa5f3d2

@xz-dev @AudricV Restyle and rename for Youtube comment extractor

f88e235

Co-authored-by: AudricV <74829229+AudricV@users.noreply.github.com>

xz-dev requested a review from AudricV October 14, 2022 02:58

AudricV approved these changes Oct 14, 2022

View reviewed changes

TobiGr merged commit 0ffcb32 into TeamNewPipe:dev Oct 15, 2022

AudricV mentioned this pull request Oct 29, 2022

Fix Checkstyle error in YoutubeCommentsInfoItemExtractor #957

Merged

1 task

This was referenced Nov 4, 2022

Release v0.24.1 TeamNewPipe/NewPipe#9290

Merged

Release v0.24.1 (PLEASE TEST!) TeamNewPipe/NewPipe#9292

Closed

TobiGr mentioned this pull request Dec 3, 2022

[SoundCloud] Add support for comment replies #993

Draft

7 tasks

Uh oh!

Conversation

xz-dev commented Sep 25, 2022

Uh oh!

TobiGr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AudricV left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xz-dev commented Sep 26, 2022

Uh oh!

TobiGr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TobiGr commented Sep 26, 2022

Uh oh!

xz-dev commented Sep 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xz-dev commented Sep 28, 2022

Uh oh!

Uh oh!

TobiGr commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TobiGr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AudricV left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AudricV left a comment

Choose a reason for hiding this comment

Uh oh!

xz-dev commented Oct 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xz-dev commented Sep 27, 2022 •

edited

Loading

TobiGr commented Oct 7, 2022 •

edited

Loading

TobiGr left a comment •

edited

Loading