Conversation
Fix for infinite loop in Brent's method Closes #861 See merge request swift/swiftsim!1743
…evel cells which aren't also super cells
Fixed issues with missing unlocks/dependencies/debug checks for top level cells which aren't also super cells See merge request swift/swiftsim!1719
GEAR-RT: theory See merge request swift/swiftsim!1744
Deadlock detector See merge request swift/swiftsim!1731
Update spin/jet AGN model See merge request swift/swiftsim!1727
Fix eagle tracers output See merge request swift/swiftsim!1761
Fix new time-step for spin-jet scheme See merge request swift/swiftsim!1762
Grackle Cooling updates See merge request swift/swiftsim!1741
Add a new potential MWPotential2014 See merge request swift/swiftsim!1717
Fix jet initial velocities Closes #866 See merge request swift/swiftsim!1764
Add forcing terms to the hydro equations See merge request swift/swiftsim!1772
Add barotropic EoS See merge request swift/swiftsim!1773
…he end of the program.
Add a function so that we can mark memory as deliberately leaked at the end of the program. Closes #867 See merge request swift/swiftsim!1771
ilectra
reviewed
Oct 9, 2023
ilectra
left a comment
ilectra
left a comment
There was a problem hiding this comment.
That's very useful, thanks! I made some typo corrections, and changed most of the "Cosma 8" mentions to "Cosma8" - I think that's the official name of the machine, and especially when you're discussing 8 nodes on "Cosma 8" it becomes really confusing :) . Please fix any that I missed!
Co-authored-by: Ilektra Christidi <ilektra.christidi@ucl.ac.uk>
Co-authored-by: Ilektra Christidi <ilektra.christidi@ucl.ac.uk>
Co-authored-by: Ilektra Christidi <ilektra.christidi@ucl.ac.uk>
Co-authored-by: Ilektra Christidi <ilektra.christidi@ucl.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more information on the
tleaffiles, the scotch strategy strings, some test case runs and future directions.