Skip to content

HPC-10213: Remove usage of legacy Dockerfile ENV syntax#128

Merged
Pl217 merged 2 commits intodevelopfrom
HPC-10213
May 12, 2025
Merged

HPC-10213: Remove usage of legacy Dockerfile ENV syntax#128
Pl217 merged 2 commits intodevelopfrom
HPC-10213

Conversation

@Pl217
Copy link
Copy Markdown
Contributor

@Pl217 Pl217 commented May 9, 2025

The syntax for ENV instructions that doesn't use an assignment operator is being phased out.

Legacy syntax: ENV var value
Current syntax: ENV var=value

Pl217 added 2 commits May 9, 2025 17:04
The syntax for `ENV` instructions that doesn't use an
assignment operator is being phased out.
docker/cli#2743

Legacy syntax: `ENV var value`
Current syntax: `ENV var=value`
@Pl217 Pl217 requested a review from a team as a code owner May 9, 2025 15:10
@Pl217 Pl217 added the ready for review All comments have been addressed, and the Pull Request is ready for review label May 9, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.95%. Comparing base (1dc7156) to head (739a486).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #128   +/-   ##
========================================
  Coverage    84.95%   84.95%           
========================================
  Files            6        6           
  Lines          452      452           
  Branches       123      123           
========================================
  Hits           384      384           
  Misses          49       49           
  Partials        19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@enxtur enxtur assigned Pl217 and unassigned enxtur May 12, 2025
@enxtur enxtur added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels May 12, 2025
@Pl217 Pl217 merged commit dca96f5 into develop May 12, 2025
6 checks passed
@Pl217 Pl217 deleted the HPC-10213 branch May 12, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants