Added support for specifying an extracted type tree data file#60
Open
paulb-unity wants to merge 6 commits intomainfrom
Open
Added support for specifying an extracted type tree data file#60paulb-unity wants to merge 6 commits intomainfrom
paulb-unity wants to merge 6 commits intomainfrom
Conversation
| Assert.AreEqual(0, await Program.Main(new string[] { "dump", m_SerializedFile, option, m_TypeTreeDataFile })); | ||
|
|
||
| var outputFiles = Directory.GetFiles(m_TestOutputFolder, "*.txt"); | ||
| Assert.IsNotEmpty(outputFiles, "Expected dump output files when TypeTree data file is provided"); |
Collaborator
There was a problem hiding this comment.
I think it would be good to check at least one expected part of content inside the dump file.
Otherwise a completely empty file would fool this test.
e.g. maybe the first line or some other simple and distinctive content.
Collaborator
Author
There was a problem hiding this comment.
added check to expect "m_GameObject (PPtr)" in the output file
Co-authored-by: Andrew Skowronski <86242170+SkowronskiAndrew@users.noreply.github.com>
…y-Technologies/UnityDataTools into typetree-extraction-support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add command line option to specify extracted type tree data file.