Improve warning messages for shiny status and batch size#2
Conversation
- Shiny warning now explicitly mentions risk of losing shiny status - Batch size warning is mode-aware instead of shiny-specific Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the buddy reroll feature to clarify the risks of rerolling a shiny companion and adjusts the warning message for large batch sizes. A review comment suggests strengthening the warning about losing shiny status from 'may lose' to 'will lose' to better reflect the immediate replacement of the current companion and the rarity of rolling a new one.
| ``` | ||
| ⚠️ Your current buddy is already Legendary ★★★★★ ✨SHINY! | ||
| Rerolling will replace your current companion. | ||
| Rerolling will replace your current companion and you may lose your shiny status. |
There was a problem hiding this comment.
The warning 'you may lose your shiny status' is technically correct but potentially misleading given the extremely low probability (0.01%) of rolling another shiny. Changing this to 'will lose' provides a clearer warning of the risk to the user's rare status, as the current companion is replaced immediately.
| Rerolling will replace your current companion and you may lose your shiny status. | |
| Rerolling will replace your current companion and you will lose your shiny status. |
1 participant
Summary
Addresses review feedback from #1.
Test plan
🤖 Generated with Claude Code