[EME] Check support for full content type string (including codecs)#1643
Open
asurdej-comcast wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.46from
Open
[EME] Check support for full content type string (including codecs)#1643asurdej-comcast wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.46from
asurdej-comcast wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.46from
Conversation
When evaluating media capability support in EME::requestMediaKeySystemAccess(), MediaPlayer::supportsType() was called with only the container MIME type (e.g. 'video/mp4'), stripping codecs and other parameters. Pass the full content type string (e.g. 'video/mp4; codecs="avc1.42E01E"') so the media engine can properly validate codec support, not just the container.
Author
|
We received a test app from Dolby that queries support for dolby types from different JS APIs (isTypeSupported, MediaCapabilites, EME). With current implementation, EME will check only the mime type of original content type string. This ignores all parameters, including codecs. "media types" here refers directly to codecs: In that sense it's reasonable to check full content type string instead of mime type only. Checking the history of that impl shows that "codecs" was part of inital impl in 79099b3 (but was ignored by MediaPlayer at that time). |
vivienne-w
added a commit
to vivienne-w/WebKit
that referenced
this pull request
Mar 25, 2026
https://bugs.webkit.org/show_bug.cgi?id=310709 Reviewed by NOBODY (OOPS!). When evaluating media capabilities for requestMediaKeySystemAccess, we use pass ParsedContentType's m_mimeType to the MediaSource, which omits parameters of the MIME type like codecs. The right field to use here is m_contentType, so MediaSource can check support against the full MIME type, rather than just its container type. * Source/WebCore/platform/encryptedmedia/CDMPrivate.cpp: (WebCore::CDMPrivate::getSupportedCapabilitiesForAudioVideoType): * Source/WebCore/platform/network/ParsedContentType.h: (WebCore::ParsedContentType::contentType const): Added, returns m_contentType. Original author: Andrzej Surdej <Andrzej_Surdej@comcast.com> See: WebPlatformForEmbedded/WPEWebKit#1643
vivienne-w
added
the
upstream
vivienne-w
added a commit
to vivienne-w/WebKit
that referenced
this pull request
Mar 26, 2026
https://bugs.webkit.org/show_bug.cgi?id=310709 Reviewed by NOBODY (OOPS!). When evaluating media capabilities for requestMediaKeySystemAccess, we use pass ParsedContentType's m_mimeType to the MediaSource, which omits parameters of the MIME type like codecs. The right field to use here is m_contentType, so MediaSource can check support against the full MIME type, rather than just its container type. * LayoutTests/media/encrypted-media/mock-navigator-requestMediaKeySystemAccess-expected.txt: * LayoutTests/media/encrypted-media/mock-navigator-requestMediaKeySystemAccess.html: Add test with supported type but unknown codec. * LayoutTests/platform/glib/TestExpectations: Unflag mock-navigator-requestMediaKeySystemAccess.html. * LayoutTests/platform/ios/TestExpectations: Ditto. * LayoutTests/platform/mac/TestExpectations: Ditto. * Source/WebCore/platform/encryptedmedia/CDMPrivate.cpp: (WebCore::CDMPrivate::getSupportedCapabilitiesForAudioVideoType): Use full contentType for MediaEngineSupportParameters. * Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp: (WebCore::MockMediaPlayerMediaSource::supportsType): Return NotSupported if codec is 'unknown' or 'invalid'. * Source/WebCore/platform/network/ParsedContentType.h: (WebCore::ParsedContentType::contentType const): Added, returns m_contentType. Original author: Andrzej Surdej <Andrzej_Surdej@comcast.com> See: WebPlatformForEmbedded/WPEWebKit#1643
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When evaluating media capability support in EME::requestMediaKeySystemAccess(), MediaPlayer::supportsType() was called with only the container MIME type (e.g. 'video/mp4'), stripping codecs and other parameters.
Pass the full content type string (e.g. 'video/mp4; codecs="avc1.42E01E"') so the media engine can properly validate codec support, not just the container.
391b3c3