Added UTM, MGRS, GARS, LatLon graticules and coordinate converters#16
Added UTM, MGRS, GARS, LatLon graticules and coordinate converters#16EMaksymenko merged 7 commits intoWorldWindEarth:developfrom EMaksymenko:feature/graticule
Conversation
emxsys
changed the title
|
@Sufaev Thanks for this pull request. I updated the description and title to conform to the SDK standards. Please review it to ensure it is correct; embellish as you see fit. Looks good. Are you already using this code in production? If so, I will approve and merge. |
|
@emxsys I have not used this feature in production yet. It was done only month ago. But I spent about three days to test all types of graticule in all level of details. I think it will be better if someone else try to test them also and confirm quality. Furthermore, I have not tested performance on low-end devices. I have no low-end devices to test. It will be good if somebody confirm that performance is good enough. But from other hand, you can merge it and we will fix it if something will go wrong. It is not a main functionality and it will not influence main code stability. |
|
@Sufaev, I ported the fixes from the WorldWindJava code-base. However, I cannot commit to this pull-request as I don't have write-access to this repository. You can get the patch I made to this pull-request if you go to this gist. You just need to view the raw file contents by clicking on the "Raw" button and then saving the text to disk as: And then on this to apply the patch to your branch. You can then push the changes to your fork. |
|
I am receiving an error: git am ~/0001-Ported-MGRS-fixes-from-WorldWindJava.patch |
|
@Sufaev, maybe try: It looks like whitespace errors. |
|
Done. Patch applied. Thanks. |
Ported the MGRS bugfixes that was made in WorldWindJava to this code-base. The description for the changes were: a) Index out of b typo in convertMGRSToUPS; clearly the index should have been 1 instead of 12. b) Conversions from geodetic to MGRS would fail for low southern latitudes (zone 0). Geotrans 3.7 has this problem fixed. The WorldWind conversion code was derived from NGA's Geotrans. Test case: Lat: -89.345400 deg, Lon: -48.930600 deg ==> MGRS: AZN 45208 47747
It is not possible to test Navigator without WorldWindow instance.
3 participants
Description of the Change
Added UTM, UPS, MGRS coordinates converters and UTM, MGRS, GARS, LatLon graticules. The code was ported from the WorldWindJava SDK.
Why Should This Be In Core?
Graticules extend the usefulness of the SDK.
Benefits
When displayed, graticules can enhance the geospatial situational awareness.
Potential Drawbacks
Unknown.
Applicable Issues
Closes #11