Make SevenzipPaths.get_locations() more robust#54
Open
nphilipp wants to merge 1 commit intoaboutcode-org:mainfrom
Open
Make SevenzipPaths.get_locations() more robust#54nphilipp wants to merge 1 commit intoaboutcode-org:mainfrom
nphilipp wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
Current Fedora Rawhide (which is to become version 43 eventually) has the proper 7zip package, which in turn doesn’t have the tool in the place expected for prior versions (with p7zip-plugins). To make the method more robust, try all known directories and binary names on Linux, but make the order in which they are checked dependent on the type of Linux distribution encountered. Signed-off-by: Nils Philippsen <nils@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Fedora Rawhide (which is to become version 43 eventually) has the proper 7zip package, which in turn doesn’t have the tool in the place expected for prior versions (with p7zip-plugins).
To make the method more robust, try all known directories and binary names on Linux, but make the order in which they are checked dependent on the type of Linux distribution encountered.