Closed
Conversation
marko-zivic-93
approved these changes
Jun 14, 2022
dmitry-shibanov
approved these changes
Jun 14, 2022
vsafonkin
approved these changes
Jun 14, 2022
brcrista
reviewed
Jun 14, 2022
| restoreKey | ||
| ); | ||
| try { | ||
| const matchedKey = await cache.restoreCache( |
Contributor
There was a problem hiding this comment.
Shouldn't we push this fix into restoreCache from actions/cache? That way everything that uses caching will handle 503s correctly.
brcrista
suggested changes
Jun 14, 2022
Contributor
brcrista
left a comment
brcrista
left a comment
There was a problem hiding this comment.
I think we should push the fix into the actions/cache package so everything gets fixed and is future-proofed
Contributor
|
#448 will fix this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR provides error handling for cache restore functionality.
Check list: