Impact
StringM::from_str does not validate that the input length is within the declared maximum (MAX). Calling StringM::<N>::from_str(s) where s is longer than N bytes succeeds and returns an Ok value instead of Err(Error::LengthExceedsMax), producing a StringM that violates its length invariant.
This affects any code that constructs StringM values from string input using FromStr (including str::parse), and relies on the type's maximum length constraint being enforced. An oversized StringM could propagate through serialization, validation, or other logic that assumes the invariant holds.
All published versions of the stellar-xdr crate up to and including v25.0.0 are affected.
Patches
The fix is merged in #500. It replaces the direct Ok(Self(b)) construction with b.try_into(), which routes through TryFrom<Vec<u8>> and properly validates the length — matching the pattern already used by BytesM::from_str.
Users should upgrade to the first release containing this fix once published (the next release after v25.0.0).
Workarounds
Validate the byte length of string input before calling StringM::from_str, or construct StringM values via StringM::try_from(s.as_bytes().to_vec()) which correctly enforces the length constraint.
References
References
leighmcculloch Remediation developer
Impact
StringM::from_strdoes not validate that the input length is within the declared maximum (MAX). CallingStringM::<N>::from_str(s)wheresis longer thanNbytes succeeds and returns anOkvalue instead ofErr(Error::LengthExceedsMax), producing aStringMthat violates its length invariant.This affects any code that constructs
StringMvalues from string input usingFromStr(includingstr::parse), and relies on the type's maximum length constraint being enforced. An oversizedStringMcould propagate through serialization, validation, or other logic that assumes the invariant holds.All published versions of the
stellar-xdrcrate up to and includingv25.0.0are affected.Patches
The fix is merged in #500. It replaces the direct
Ok(Self(b))construction withb.try_into(), which routes throughTryFrom<Vec<u8>>and properly validates the length — matching the pattern already used byBytesM::from_str.Users should upgrade to the first release containing this fix once published (the next release after
v25.0.0).Workarounds
Validate the byte length of string input before calling
StringM::from_str, or constructStringMvalues viaStringM::try_from(s.as_bytes().to_vec())which correctly enforces the length constraint.References
References