Add support to enable and disable scrolling as well a fix for fling disable#453
Closed
fouadkada wants to merge 6 commits intoalamkanak:developfrom
fouadkada:develop
Closed
Add support to enable and disable scrolling as well a fix for fling disable#453fouadkada wants to merge 6 commits intoalamkanak:developfrom fouadkada:develop
fouadkada wants to merge 6 commits intoalamkanak:developfrom
fouadkada:develop
Conversation
…crolling are enabled
… conditions are correctly evaluated
Author
|
make id of type object so that an id can be a string. useful when fetching events from a server and each event has a string ID |
ccparram
reviewed
Jan 19, 2018
|
|
||
| mCurrentFlingDirection = mCurrentScrollDirection; | ||
|
|
||
| if ((mCurrentFlingDirection == Direction.LEFT && !mHorizontalFlingEnabled) || |
There was a problem hiding this comment.
I thinks is necessary add a new validation here, to disable the fling if scroll is disabled.
if ((mCurrentFlingDirection == Direction.LEFT && !mHorizontalFlingEnabled || !mHorizontalScrollEnabled) || (mCurrentFlingDirection == Direction.RIGHT && !mHorizontalFlingEnabled || !mHorizontalScrollEnabled) || (mCurrentFlingDirection == Direction.VERTICAL && !mVerticalFlingEnabled || !mVerticalScrollEnabled)) { return true; }
This reverts commit bad564e.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.