thb/fix-283

[tbillon]

This PR revert PR #215 to address #283. To make things more consistent, make an empty list raise an exception like an empty dict.

So an empty dict gets its path variable back:

>>> from voluptuous import Schema
>>> Schema({})({"extra": "invalid", "extra2": "invalid", })
Traceback (most recent call last):
...
voluptuous.error.MultipleInvalid: extra keys not allowed @ data['extra2']

And now an empty list also raise a MultipleInvalid exception and set the path variable:

>>> from voluptuous import Schema
>>> Schema([])(['list_invalid', 'list_invalid2'])
Traceback (most recent call last):
...
voluptuous.error.MultipleInvalid: not a valid value @ data['list_invalid']

[coveralls]

Coverage increased (+0.009%) to 95.319% when pulling 6af92d1 on tbillon:thb/fix-283 into 77ee5da on alecthomas:master.

[brmzkw]

Any plan to merge this?

[tusharmakkar08]

I am not sure about this since it is contrast with the issue mentioned here. @alecthomas Please look into this.

[brmzkw]

hi :)

[tusharmakkar08]

Hey @brmzkw

I can't take a call on this alone. Would require @alecthomas approval for the same.

Thanks.

[alecthomas]

LGTM, thanks.

[brmzkw]

since backward compat was broken, do you think you can make a release soon?

[tuukkamustonen]

@tbillon Care to clarify this change a bit:

1. So the change here was to revert {} behavior - if extra=True it allows extra params (inherited) and if not then it doesn't? Correct me if wrong.
2. Why remove whole test_empty_dict_as_exact() and not modify it (most parts still apply)?
3. This change is marked as fix in CHANGELOG.md - should it be marked as change instead?