make Schema.__eq__ deterministic#316
Merged
tusharmakkar08 merged 4 commits intoalecthomas:masterfrom Dec 7, 2017
Merged
Conversation
This fills in missing test coverage to ensure the __eq__ method does not return True in some potentially unexpected cases (these tests would fail before be867c5).
Previously only the __eq__ method was implemented, which could lead to
surprising behavior e.g.:
Schema('foo') == Schema('foo') # True
Schema('foo') != Schema('foo') # True
This adds the __ne__ method so that these operators are complementary as
one might expect.
Contributor
Author
|
Update: after adding some more tests for this, I noticed that the |
tusharmakkar08
requested changes
Dec 7, 2017
Collaborator
tusharmakkar08
left a comment
tusharmakkar08
left a comment
There was a problem hiding this comment.
Hey @dtao
Thanks for the prompt response. This PR looks good to me. Please squash your commits and let's get it merged.
Thanks.
Owner
|
@tusharmakkar08 you should be able to Squash and merge the branch through GitHub:
|
tusharmakkar08
approved these changes
Dec 7, 2017
Collaborator
|
@alecthomas Didn't know it existed 😅 |
This was referenced Feb 15, 2018
This was referenced Feb 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test to highlight the issue raised in #315 and proposes a solution: instead of comparing
str(self.schema)withstr(other), just compareschemaattributes directly.