Handle incomparable values in Range#414
Merged
alecthomas merged 2 commits intoalecthomas:masterfrom Nov 28, 2019
Merged
Conversation
In Python3 some values that are comparable in Python2 are no longer comparable. One instance of this is None, which in Python2 is always less than any other object. In Python3, however, a TypeError is raised if it is used in a comparison. This commit handles said TypeError and issues a RangeInvalid exception instead.
Owner
|
Seems reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python3, some values that are comparable in Python2, are no longer
comparable. One instance of this is None, which in Python2 is always
less than any other object. In Python3, however, a TypeError is raised
if it is used in a comparison.
This commit series adds unit tests for this in the Range validator, and follows it up with adding a fix for the error.