Don't enforce type for unused description attribute#519
Merged
alecthomas merged 1 commit intoalecthomas:masterfrom Jun 26, 2024
cdce8p:description-type
Merged
Don't enforce type for unused description attribute#519alecthomas merged 1 commit intoalecthomas:masterfrom cdce8p:description-type
alecthomas merged 1 commit intoalecthomas:masterfrom
cdce8p:description-type
Conversation
bdraco
approved these changes
Jun 26, 2024
Contributor
Author
|
@alecthomas If you have some time, it would be great if you could take a look at this one and #521. These two are the last remaining changes needed for Home Assistant. After they are merged, a new release ( |
Contributor
|
Thank you !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the docstring, the
descriptionattribute is unused by voluptuous itself but can be used by external tools. It therefore shouldn't force the type to bestr | None. If the tool prefersdict, that should be valid as well.Refs home-assistant/core#120268