Merged
Conversation
This reverts commit f4e86ec.
Owner
|
Thank you! I recently landed #231 which vastly simplifies our build process (no more cross-OS cross compiling), and I've added some commits to your PR to merge these changes. |
amacneil
reviewed
Dec 29, 2021
| run: | | ||
| set -x | ||
| docker-compose build | ||
| docker buildx bake --load --set "*.platform=linux/amd64" |
Owner
There was a problem hiding this comment.
What does this do / why is it necessary?
amacneil
reviewed
Dec 29, 2021
| push: ${{ github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/v') }} | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max |
Owner
There was a problem hiding this comment.
Would this cache be used for the previous docker build step? If not, it seems like it would do more harm than good (building twice with different caches rather than reusing the same cache).
I'm going to remove it for now until I can do further testing, but let me know your thoughts.
amacneil
force-pushed
the
add-arm-build
branch
from
e136f52 to
eae114d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This publishes multiarch (arm64 and amd64) images to DockerHub and GitHub Container Registry