DatePicker problems with Angular 1.1.5

[Swiip]

I updated AngularUI Bootstrap to the new version 0.0.5 in order to use ne new popup feature.

I use :
Angular UI Boostrap 0.5.0
Angular JS 1.1.5
No jQuery

I identified two problems so far (in addition to this one: #758) :

• Error on the initial $document.unbind in scope.$watch('isOpen'...
• Interpretation problem on the open attributes. With AngularJS 1.1.5, it seems that it always be true so the button doesnt work. I only succeed to patch this by changing the attribute name.

I wrote a Plunkr to illustrate : http://plnkr.co/edit/vAiD5v?p=preview
Search for //PATCH in bootstrap.js to find the patches. These patchs are ugly and I know this need better workarounds.

If this is confirmed, I can submit a pull request with real corrections...

Matthieu

[bekos]

@Swiip Thx for your report and your help getting this correct.

• The unbind error is thrown because we try to unbind even if haven't previously bind the listener.
  The patch (fix(jqLite): forgive unregistration of a non-registered handler angular/angular.js#3465) from @pkozlowski-opensource will probably fix this, otherwise we will have to change from unconditional binding for document & focus, because I don't like the try block. I believe the patch will be merged soon, so we may not bother ourselves with this, but @pkozlowski-opensource knows better.
• You are right. I don't know if this is a know bug in AngualrJS or if something else causes this, but changing the attribute name seems to make the button work.

A PR at least for the attribute name atm would be nice!

[pkozlowski-opensource]

@bekos @Swiip even if the patch from angular/angular.js#3465 gets accepted (which I'm sure it will in this form or another) it will make it into AngularJS 1.0.8 the earliest. Which means we will still have tons of broken AngularJS versions... This is why I've decided to patch it somehow in the tooltip. Not sure if there is a way of providing a work-around in the date-picker...

For the open stuff I start to vaguely remember something, would have to go back to the history of commits for 1.1.x...

[bekos]

@Swiip Do you care to open a PR sorting these problems? I would appreciate avoiding the try blocks & about the attribute name, other than be a breaking change, I don't think we should bother more.

[Swiip]

Alright I'll work on a real PR and of course the try block is awful and was only a way to test quickly.

For the open, I'll do some search to understand what is going on...

[yong3gao1]

These changes don't seem to be included in the official releases at https://gh.lumenfield.work/angular-ui/bootstrap/tree/gh-pages. A custom build with the datapicker module did not work with angular 1.1.5

Is there a plan to update the official releases?

[pkozlowski-opensource]

@yong3gao1 we did a release only a week ago, we will need couple of more weeks before 0.6.0. You can clone this repository and build master branch if you need those changes earlier on.

[yong3gao1]

I did a build successfully following the instructions in README.md. Thanks.
Yong