fix(@angular/cli): handle duplicate arguments#22966
Merged
dgp1130 merged 1 commit intoangular:masterfrom Apr 11, 2022
alan-agius4:parser-middleware
Merged
fix(@angular/cli): handle duplicate arguments#22966dgp1130 merged 1 commit intoangular:masterfrom alan-agius4:parser-middleware
dgp1130 merged 1 commit intoangular:masterfrom
alan-agius4:parser-middleware
Conversation
alan-agius4
added
the
target: major
alan-agius4
added
the
action: review
clydin
reviewed
Apr 11, 2022
Member
clydin
left a comment
clydin
left a comment
There was a problem hiding this comment.
Nice idea with the middleware.
packages/angular/cli/src/command-builder/utilities/normalize-options-middleware.ts
Outdated
Show resolved
Hide resolved
packages/angular/cli/src/command-builder/utilities/normalize-options-middleware.ts
Show resolved
Hide resolved
With this change we add a Yargs middleware that normalizes non Array options when the argument has been provided multiple times. By default, when an option is non array and it is provided multiple times in the command line, yargs will not override it's value but instead it will be changed to an array unless `duplicate-arguments-array` is disabled. But this option also have an effect on real array options which isn't desired. See: yargs/yargs-parser#163 (comment) Closes #22956
clydin
approved these changes
Apr 11, 2022
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we add a Yargs middleware that normalizes non Array options when the argument has been provided multiple times.
By default, when an option is non array and it is provided multiple times in the command line, yargs
will not override it's value but instead it will be changed to an array unless
duplicate-arguments-arrayis disabled.But this option also have an effect on real array options which isn't desired.
See: yargs/yargs-parser#163 (comment)
Closes #22956