This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(util-fns): generalize getExampleName()#1666
Closed
chalin wants to merge 1 commit intoangular:masterfrom
Closed
docs(util-fns): generalize getExampleName()#1666chalin wants to merge 1 commit intoangular:masterfrom
chalin wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
Author
|
@Foxandxss : ready for review and merge. |
Member
|
So with this, we can define a _example variable in the .jade so we can do better on the example paths through the jade? |
Contributor
Author
|
Yes. E.g., - var _example = 'toh-6';at the top. Then the functions and mixins in the |
7eec8d8 to
b2687ba
Compare
b2687ba to
e7a2c34
Compare
Contributor
Author
|
Subsumed by #1686 (since this was a necessary change for toh-6). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some chapters the Jade source file name (e.g.,
toh-pt6.jade) does not match with the example directory name (toh-6). For such cases, we can now set_exampleto, saytoh-6;getExampleName()will now use_exampleif set, otherwise determine the name fromcurrentas it did before.