This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(dependency-injection): add Dart version, tweak TS version#972
Closed
kwalrath wants to merge 20 commits intoangular:masterfrom
Closed
docs(dependency-injection): add Dart version, tweak TS version#972kwalrath wants to merge 20 commits intoangular:masterfrom
kwalrath wants to merge 20 commits intoangular:masterfrom
Conversation
| class AppComponent { | ||
| UserService _userService; | ||
| final UserService _userService; | ||
| String title; |
Contributor
There was a problem hiding this comment.
Cleaner to have title final since we should set it only once for the lifetime of the app.
kwalrath
force-pushed
the
dart-dependency-injection-2
branch
from
1cf6d2f to
a28000a
Compare
Contributor
Author
still more to do...
kwalrath
force-pushed
the
dart-dependency-injection-2
branch
from
a28000a to
e51f569
Compare
Contributor
Author
|
@wardbell: This might be done, but I'm going to take another look tomorrow before committing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of changes started in #951.
I've finished incorporating @thso's initial feedback, but we're not done yet. (See the PENDINGs.)