Skip to content

kvm: Enable virtio drivers based on guest os display name #3879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 3 commits into from
Feb 19, 2020
Merged

kvm: Enable virtio drivers based on guest os display name #3879

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ea0e90
kvm: Enable virtio drivers based on guest os display name
ustcweizhou Feb 11, 2020
d6fae5a
fall back if null
DaanHoogland Feb 14, 2020
8d69839
use Other instead unknown
ustcweizhou Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/main/java/com/cloud/hypervisor/KVMGuru.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public VirtualMachineTO implement(VirtualMachineProfile vm) {
guestOsMapping = _guestOsHypervisorDao.findByOsIdAndHypervisor(guestOS.getId(), getHypervisorType().toString(), host.getHypervisorVersion());
}
if (guestOsMapping == null || host == null) {
to.setPlatformEmulator("Other");
to.setPlatformEmulator(guestOS.getDisplayName());
Copy link
Copy Markdown
Member

@yadvr yadvr Feb 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ustcweizhou how about we check and fallback to "Other" in case guestOS.getDisplayName() is null or empty (unlikely but just to make code more defensive)?

} else {
to.setPlatformEmulator(guestOsMapping.getGuestOsName());
}
Expand Down