Catch warnings in FFI unit tests#1410
Merged
timsaucer merged 2 commits intoapache:mainfrom Mar 7, 2026
Merged
Conversation
Member
Author
|
Demonstration of failed jobs: https://github.com/apache/datafusion-python/actions/runs/22733604347/job/65931026342?pr=1410 |
timsaucer
force-pushed
the
test/catch-log-warnings
branch
from
89d5d15 to
8442412
Compare
davisp
approved these changes
Mar 6, 2026
|
|
||
| #[pymodule] | ||
| fn datafusion_ffi_example(m: &Bound<'_, PyModule>) -> PyResult<()> { | ||
| pyo3_log::init(); |
kevinjqliu
approved these changes
Mar 6, 2026
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM i tested this out locally
CI run looks good too
Member
Author
|
Thank you @davisp and @kevinjqliu ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None, but related to apache/datafusion#20704
Rationale for this change
Right now we have unit tests that are generating warnings. These could have helped us catch the issue above before it got released. Instead the warnings were silently ignored. With this PR we will prevent future warnings from getting through CI.
What changes are included in this PR?
Initialize logging in example crate.
Add check for warnings in unit tests.
Are there any user-facing changes?
No, CI only.