Open
Conversation
iffyio
reviewed
Mar 26, 2026
Contributor
iffyio
left a comment
There was a problem hiding this comment.
Thanks @xitep! The changes look reasonable to me overall
Just sanity checking this assumption:
Tests work only because the parser in the tests sets all tokens' spans to "empty"; ie. there is not "magic" wrt to PartialEq/Eq like for the AttachedToken
Is it rather the case that the tests aren't affected due to the eq impl here?
Contributor
Author
|
ah, indeed! yes, you are right. it's because of that partial-eq impl. i was mislead by |
`Deref/Mut<Target = Value>` for `ValueWithSpan`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueWithSpanallowing clients to get hold of the location/span for 1) error reporting and 2) associating metadata with the visited values (the start location can be used to make up an identifier)Ident) exposing their span in the ASTDeref<Target = Value> for ValueWithSpanwould make an upgrade to this version less hassle: