Skip to content

[fix](azure) Fix incorrect modification timestamps in AzureObjStorage #61790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Mar 29, 2026
+4 −3
Merged

[fix](azure) Fix incorrect modification timestamps in AzureObjStorage #61790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions fe/fe-core/src/main/java/org/apache/doris/fs/obj/AzureObjStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,8 @@ public Status globList(String remotePath, List<RemoteFile> result, boolean fileN
!isPrefix,
isPrefix ? -1 : blobItem.getProperties().getContentLength(),
isPrefix ? -1 : blobItem.getProperties().getContentLength(),
isPrefix ? 0 : blobItem.getProperties().getLastModified().getSecond());
isPrefix ? 0 : blobItem.getProperties().getLastModified()
.toInstant().toEpochMilli());
Comment on lines +428 to +429
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add/extend unit tests (e.g., AzureObjStorageTest’s mocked paged listing) to assert RemoteFile.modificationTime is an epoch-millisecond value derived from BlobItemProperties.getLastModified().toInstant().toEpochMilli(), so regressions back to second-of-minute/epoch-seconds are caught.

Copilot uses AI. Check for mistakes.
result.add(remoteFile);

blobPath = blobPath.getParent();
Expand Down Expand Up @@ -500,7 +501,7 @@ private Status globListByGetProperties(String bucket, String keyPattern,
props.getBlobSize(),
props.getBlobSize(),
props.getLastModified() != null
? props.getLastModified().toEpochSecond() : 0
? props.getLastModified().toInstant().toEpochMilli() : 0
);
Comment on lines 503 to 505
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test coverage for the deterministic-path getProperties/HEAD flow to validate the modification time unit is epoch milliseconds (not epoch seconds). Using a fixed OffsetDateTime in mocks will make the assertion deterministic.

Copilot uses AI. Check for mistakes.
result.add(remoteFile);

Expand Down Expand Up @@ -561,7 +562,7 @@ public Status listFiles(String remotePath, boolean recursive, List<RemoteFile> r
false,
props.getContentLength(),
props.getContentLength(),
props.getLastModified().getSecond(),
props.getLastModified().toInstant().toEpochMilli(),
null);
Comment on lines 563 to 566
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a unit test around listFiles() (or a small isolated helper) to assert BlobItemProperties.getLastModified is converted to epoch milliseconds, since this path previously returned an incorrect value and is easy to regress.

Copilot uses AI. Check for mistakes.
result.add(file);
}
Expand Down
Loading