FINERACT-2510: Resolve compilation warnings in fineract-core

[Ambika-Sony]

Description

The details regarding these changes are present on the associated Apache Fineract JIRA ticket.
Summary of work:
Resolved 45 compilation warnings in the fineract-core module,
Replaced deprecated ObjectUtils.defaultIfNull and Date(String) constructor.
Fixed unchecked casts and raw type usage in DataEnricherProcessor and InternalExternalEventService.
Verified the module now compiles cleanly with a "BUILD SUCCESSFUL" status.

• [x ] Write the commit message as per our guidelines
• [ x] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• [x ] Create/update unit or integration tests for verifying the changes made.
• [ x] Follow our coding conventions.
• [ x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• [ x] This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[IOhacker]

Please Squash & Commit

[Ambika-Sony]

Please Squash & Commit

did it

[airajena]

Please Squash & Commit

did it

@Ambika-Sony please run ./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest as pre commit checks
Execution failed for task ':fineract-core:spotlessJavaCheck'.

[Incubating] Problems report is available at: file:///home/runner/work/fineract/fineract/build/reports/problems/problems-report.html

The following files had format violations:
src/main/java/org/apache/fineract/infrastructure/core/service/DataEnricherProcessor.java
@@ -34,7 +34,7 @@
········this.enhancers·=·enhancers.orElse(new·ArrayList<>());
····}

      -····@SuppressWarnings({"unchecked",·"rawtypes"})
      +····@SuppressWarnings({·"unchecked",·"rawtypes"·})
       ····public·<T>·T·enrich(T·source)·{
       ········for·(DataEnricher·enhancer·:·enhancers)·{
       ············if·(enhancer.isDataTypeSupported(source.getClass()))·{

Run './gradlew :fineract-core:spotlessApply' to fix these violations.

• Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Get more help at https://help.gradle.org./`
`

[Ambika-Sony]

Please Squash & Commit

did it

@Ambika-Sony please run ./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest as pre commit checks Execution failed for task ':fineract-core:spotlessJavaCheck'.

[Incubating] Problems report is available at: file:///home/runner/work/fineract/fineract/build/reports/problems/problems-report.html

The following files had format violations:
src/main/java/org/apache/fineract/infrastructure/core/service/DataEnricherProcessor.java
@@ -34,7 +34,7 @@
········this.enhancers·=·enhancers.orElse(new·ArrayList<>());
····}

      -····@SuppressWarnings({"unchecked",·"rawtypes"})
      +····@SuppressWarnings({·"unchecked",·"rawtypes"·})
       ····public·<T>·T·enrich(T·source)·{
       ········for·(DataEnricher·enhancer·:·enhancers)·{
       ············if·(enhancer.isDataTypeSupported(source.getClass()))·{

Run './gradlew :fineract-core:spotlessApply' to fix these violations.

• Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Get more help at [https://help.gradle.org./](https://help.gradle.org./%60)

I'v successfully run spotlessApply, spotbugs, and checkstyle locally as requested, and the build is passing. Thank you for the guidance.

[adamsaghy]

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':integration-tests:spotlessJavaCheck'.
> The following files had format violations:
      src/test/java/org/apache/fineract/integrationtests/SavingsAccountsExternalIdTest.java
          @@ -20,7 +20,6 @@
           
           import·static·org.assertj.core.api.Assertions.assertThat;
           
          -import·java.math.BigDecimal;
           import·java.time.format.DateTimeFormatter;
           import·java.util.UUID;
           import·org.apache.fineract.client.models.DeleteSavingsAccountsAccountIdResponse;
          @@ -78,7 +77,8 @@
           ········PutSavingsAccountsAccountIdRequest·request·=·new·PutSavingsAccountsAccountIdRequest();
           ········request.setLocale(locale);
           ········request.setNominalAnnualInterestRate(5.999);
          -········Response<PutSavingsAccountsAccountIdResponse>·response·=·okR(fineractClient().savingsAccounts.updateSavingsAccount(EXTERNAL_ID,·request,·""));
          +········Response<PutSavingsAccountsAccountIdResponse>·response·=·okR(

[Incubating] Problems report is available at: file:///home/runner/work/fineract/fineract/build/reports/problems/problems-report.html
          +················fineractClient().savingsAccounts.updateSavingsAccount(EXTERNAL_ID,·request,·""));
           
           ········assertThat(response.isSuccessful()).isTrue();
           ····}
          @@ -101,7 +101,8 @@
           ····@Order(4)
           ····void·retrieveSavingsAccountWithExternalId()·{
           ········LOG.info("------------------------------·RETRIEVING·SAVINGS·ACCOUNT·---------------------------------------");
          -········Response<SavingsAccountData>·response·=·okR(fineractClient().savingsAccounts.retrieveSavingsAccount(EXTERNAL_ID,·false,·null,·"all"));
          +········Response<SavingsAccountData>·response·=·okR(
          +················fineractClient().savingsAccounts.retrieveSavingsAccount(EXTERNAL_ID,·false,·null,·"all"));
           
           ········assertThat(response.isSuccessful()).isTrue();
           ········assertThat(response.body().getStatus().getCode()).isEqualTo("savingsAccountStatusType.approved");
          @@ -122,7 +123,8 @@
           ····@Order(6)
           ····void·retrieveSavingsAccountWithExternalIdSecondTime()·{
           ········LOG.info("------------------------------·RETRIEVING·SAVINGS·ACCOUNT·-·SECOND·TIME·---------------------------------------");
          -········Response<SavingsAccountData>·response·=·okR(fineractClient().savingsAccounts.retrieveSavingsAccount(EXTERNAL_ID,·false,·null,·"all"));
          +········Response<SavingsAccountData>·response·=·okR(
          +················fineractClient().savingsAccounts.retrieveSavingsAccount(EXTERNAL_ID,·false,·null,·"all"));
           
           ········assertThat(response.isSuccessful()).isTrue();
           ········assertThat(response.body().getStatus().getCode()).isEqualTo("savingsAccountStatusType.submitted.and.pending.approval");
          @@ -146,4 +148,4 @@
           
           ········assertThat(response.raw().code()).isEqualTo(404);
           ····}
          -}
          +}
  Run './gradlew :integration-tests:spotlessApply' to fix these violations.

[adamsaghy]

@Ambika-Sony Gentle reminder.

[adamsaghy]

@Ambika-Sony Can you please rebase this PR with latest develop branch? These failing checks are weird... :/

[Ambika-Sony]

@Ambika-Sony Can you please rebase this PR with latest develop branch? These failing checks are weird... :/

Hi @adamsaghy, I have rebased the PR with the latest develop branch and force-pushed the updated changes. The local build is passing. Could you please re-check the failing compatibility checks?