FINERACT-2515: Fix the TODO comments in the Apache Fineract Code

[nidhiii128]

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[IOhacker]

@nidhiii128 there are conflicts in the PR to be solved

[nidhiii128]

@IOhacker i have solved the conflicts and rebased the branch onto the latest develop and updated the liquibase sequence to include my new 0219 from 0218.

[adamsaghy]

@nidhiii128 Kindly review the failing tests cases.

[nidhiii128]

@nidhiii128 Kindly review the failing tests cases.

yes i have now checked all ci checks green, no failing tests.

[adamsaghy]

I dont really understand some of the changes of this PR... :/

[nidhiii128]

Hi @adamsaghy , As I'm still getting up to speed with the project's standards, I wasn't initially aware of the return type inconsistency or the best way to handle the Enum refactoring, but I have now implemented the fromInt method with proper null-safety and updated the return types to Integer as requested. I have also removed the TODO comments to ensure the code is clean and won't cause confusion for other developers. I also realized my previous push contained unrelated files due to a messy local history, so I have cleaned up the branch into a single focused commit and added a new unit test class to verify the logic.

[adamsaghy]

@nidhiii128 Gentle reminder.

[nidhiii128]

hii @adamsaghy sorry for the delay there were a lot files to modify as I dig into removing the todos. please review it and let me know if any changes needed to be done. Thank you :}

[nidhiii128]

Hii @adamsaghy can you please review the pr? all ci checks are green. Let me know if any further modifications are needed.

[adamsaghy]

LGTM