Skip to content

Implement basic support for rest.sigv4_enabled for the Iceberg REST catalog#917

Closed
phillipleblanc wants to merge 19 commits intoapache:mainfrom
spiceai:phillip/250127-rest-sigv4-upstream
Closed

Implement basic support for rest.sigv4_enabled for the Iceberg REST catalog#917
phillipleblanc wants to merge 19 commits intoapache:mainfrom
spiceai:phillip/250127-rest-sigv4-upstream

Conversation

@phillipleblanc
Copy link
Copy Markdown
Contributor

@phillipleblanc phillipleblanc commented Jan 27, 2025

Implements basic support for connecting to the AWS Glue Iceberg REST catalog by supporting the parameters rest.sigv4-enabled, rest.signing-name and rest.signing-region. See the corresponding parameters in the PyIceberg docs: https://py.iceberg.apache.org/configuration/#rest-catalog

I've added a new feature to the iceberg-catalog-rest called sigv4 which when enabled, will recognize the above configuration parameters. I've left this disabled by default.

I added the crate request_middleware to allow running middleware on requests, and if the rest.sigv4-enabled configuration is enabled, the middleware to sign the request and add the correct Authorization header is enabled.

I've tested this implementation in my project, and it works great for connecting to the AWS Glue REST catalog, i.e. https://glue.<region>.amazonaws.com/iceberg

I based this logic on the equivalent logic in PyIceberg: https://github.com/apache/iceberg-python/blob/6fffb644518bb64e8f33883d850edbe18c12bd07/pyiceberg/catalog/rest.py#L475

@simonvandel
Copy link
Copy Markdown

Hi @phillipleblanc

I found this PR while digging into how to query AWS' REST catalog implementation for S3 Tables.
What would it take to get this PR merged? How can I assist?

@phillipleblanc
Copy link
Copy Markdown
Contributor Author

Hi @phillipleblanc

I found this PR while digging into how to query AWS' REST catalog implementation for S3 Tables. What would it take to get this PR merged? How can I assist?

I think we might need to rework this to not depend on the aws crates for the signing part - that seems to have some conflicts I wasn't able to resolve with the MSRV check. Looking at how the object_store crate does it would be a good start: https://github.com/apache/arrow-rs-object-store/blob/main/src/aws/credential.rs

@phillipleblanc
Copy link
Copy Markdown
Contributor Author

Closing because #1241 should be the preferred approach.

sgrebnov pushed a commit to spiceai/iceberg-rust that referenced this pull request Sep 25, 2025
peasee pushed a commit to spiceai/iceberg-rust that referenced this pull request Oct 27, 2025
lukekim pushed a commit to spiceai/iceberg-rust that referenced this pull request Jan 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2026

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants