[improve][client] add physicalAddress as part of connection pool key

[heesung-sohn]

Motivation

Context: https://github.com/apache/pulsar/pull/22085/files#r1497008116

Currently, the connection pool key does not include physicalAddress (currently logicalAddress + keySuffix). This can be a problem when the same logicalAddresses are in the migrated(green) cluster. (the connection pool will return the connection to the old(blue) cluster)

Modifications

Add physicalAddress as part of the connection pool key

Verifying this change

• Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[github-actions]

@heesung-sn Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

[lhotari]

The Key looks good now. One more refactoring suggestion.

[lhotari]

LGTM

[lhotari]

Good work @heesung-sn

[codecov-commenter]

Codecov Report

❌ Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.55%. Comparing base (bbc6224) to head (c716ce6).
⚠️ Report is 1260 commits behind head on master.

Files with missing lines	Patch %	Lines
.../org/apache/pulsar/client/impl/ConnectionPool.java	76.00%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22196      +/-   ##
============================================
- Coverage     73.57%   73.55%   -0.02%     
- Complexity    32624    32653      +29     
============================================
  Files          1877     1878       +1     
  Lines        139502   139634     +132     
  Branches      15299    15328      +29     
============================================
+ Hits         102638   102711      +73     
- Misses        28908    28929      +21     
- Partials       7956     7994      +38     

Flag	Coverage Δ
inttests	26.63% <48.00%> (+2.05%)	⬆️
systests	24.22% <48.00%> (-0.10%)	⬇️
unittests	72.84% <76.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../org/apache/pulsar/client/impl/ConnectionPool.java	75.62% <76.00%> (+1.10%)	⬆️

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lhotari]

@poorbarcode Do we need this fix in branch-3.0?