SOLR-17715: Remove qt parameter from the final parameters sent to server#3441
SOLR-17715: Remove qt parameter from the final parameters sent to server#3441r4mercur wants to merge 1 commit intoapache:mainfrom r4mercur:jira/SOLR-17715-r4mercur
Conversation
|
Coming back to this, I think this is close to what we should do. But I'd rather see the path extracted in the constructor so that QueryRequest no longer overrides getPath. Also the placement of these tests seems arbitrary/wrong to me, but the tests themselves are very good. Can you please create a new PR? If you are no longer interested, I'll maybe tell an AI agent to do this. |
|
I was just updating a downstream plugin for Solr and it had |
|
And add a new constructor to QueryRequest to put the path first explicitly without resorting to "qt" param. The others can be deprecated. |
|
@dsmiley one question before i would start a new try to tackle this. Where would you see the tests-cases best placed ? |
|
Just start a new testcase, as I see no existing one. Thanks for your interest! |
https://issues.apache.org/jira/browse/SOLR-17715
Description
Please provide a short description of the changes you're making with this pull request.
Solution
Please provide a short description of the approach taken to implement your solution.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.