Skip to content

SOLR-17715: Remove qt parameter from the final parameters sent to server#3441

Closed
r4mercur wants to merge 1 commit intoapache:mainfrom
r4mercur:jira/SOLR-17715-r4mercur
Closed

SOLR-17715: Remove qt parameter from the final parameters sent to server#3441
r4mercur wants to merge 1 commit intoapache:mainfrom
r4mercur:jira/SOLR-17715-r4mercur

Conversation

@r4mercur
Copy link
Copy Markdown
Contributor

@r4mercur r4mercur commented Jul 25, 2025

https://issues.apache.org/jira/browse/SOLR-17715

Description

Please provide a short description of the changes you're making with this pull request.

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@r4mercur r4mercur closed this Jul 25, 2025
@r4mercur r4mercur deleted the jira/SOLR-17715-r4mercur branch July 25, 2025 16:43
@dsmiley
Copy link
Copy Markdown
Contributor

dsmiley commented Apr 30, 2026

Coming back to this, I think this is close to what we should do. But I'd rather see the path extracted in the constructor so that QueryRequest no longer overrides getPath.

Also the placement of these tests seems arbitrary/wrong to me, but the tests themselves are very good. Can you please create a new PR? If you are no longer interested, I'll maybe tell an AI agent to do this.

@epugh
Copy link
Copy Markdown
Contributor

epugh commented Apr 30, 2026

I was just updating a downstream plugin for Solr and it had qt and it would be so nice to get rid of it!

@dsmiley
Copy link
Copy Markdown
Contributor

dsmiley commented Apr 30, 2026

And add a new constructor to QueryRequest to put the path first explicitly without resorting to "qt" param. The others can be deprecated.

@r4mercur
Copy link
Copy Markdown
Contributor Author

r4mercur commented May 1, 2026

@dsmiley one question before i would start a new try to tackle this. Where would you see the tests-cases best placed ?

@dsmiley
Copy link
Copy Markdown
Contributor

dsmiley commented May 1, 2026

Just start a new testcase, as I see no existing one.

Thanks for your interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants