This repository was archived by the owner on Dec 16, 2025. It is now read-only.
Revert "Handle for LSP textDocument/formatting request (#64)"#73
Merged
charliermarsh merged 1 commit intomainfrom Feb 19, 2023
Merged
Revert "Handle for LSP textDocument/formatting request (#64)"#73charliermarsh merged 1 commit intomainfrom
charliermarsh merged 1 commit intomainfrom
Conversation
This reverts commit e1925b0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some discussion in #64, I think it makes sense to roll this back. I included it as ESLint supports it, but (1) I get the sense that ESLint considers it an anti-pattern, and (2) we don't have the same capabilities to conditionally enable this capability in the server (or, at least, we'd need to spend more time exploring how to do that properly).