Conversation
Contributor
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/cli@0.0.47-pr.425.8bf8063Prefer not to change any import paths? Install using npm alias so your code still imports npm i "base44@npm:@base44-preview/cli@0.0.47-pr.425.8bf8063"Or add it to your {
"dependencies": {
"base44": "npm:@base44-preview/cli@0.0.47-pr.425.8bf8063"
}
}
Preview published to npm registry — try new features instantly! |
2f0e68a to
97403bd
Compare
artemdemo
reviewed
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Maybe logger should be a separate package?
wdyt?
Collaborator
Author
There was a problem hiding this comment.
Love this idea, what do you think about the name @base44-cli/logger? maybe just @base44/logger?
1bd5790 to
2ddd779
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Description
This PR extracts the logger abstraction into a dedicated
@base44-cli/loggermonorepo package and wires it throughCLIContextso every command receives the correct logger implementation automatically. In interactive (TTY) mode aClackLoggerdelegates to@clack/prompts; in non-interactive/CI mode aSimpleLoggerwrites plain text to stderr. Commands no longer importlogfrom@clack/promptsdirectly — they destructurelog(orlogger) from the injectedCLIContext.Related Issue
None
Type of Change
Changes Made
packages/loggerworkspace package (@base44-cli/logger) with aLoggerinterface,ClackLogger(interactive), andSimpleLogger(CI/piped output to stderr)log: Loggerfield toCLIContextand instantiated the right implementation incli/index.tsbased onisNonInteractiveBase44Commandto injectCLIContextas the first argument to all action functions, replacing the old approach of accessing context viacommand.isNonInteractiveisNonInteractivegetter fromBase44Command(context is now passed directly)ensureAuthandensureAppConfigmiddleware to acceptCLIContextinstead of a bareErrorReporterlogfromCLIContextinstead of importinglogfrom@clack/promptsdocs/commands.mdto document the newCLIContext-injection pattern andLoggerusagetsconfig.base.jsonto the repo root; updatedpackages/logger/tsconfig.jsonto extend itTesting
npm test)Checklist
docs/(AGENTS.md) if I made architectural changesAdditional Notes
The
Loggerinterface maps 1:1 to@clack/promptslog methods, so future callers are familiar with the API.SimpleLoggerwrites tostderrto keepstdoutclean for machine-readable output in CI pipelines.🤖 Generated by Claude | 2026-03-19 00:00 UTC